This repository was archived by the owner on Nov 22, 2024. It is now read-only.
View Source should always open a ChromeCustomTab, fix #41#42
Open
SimonMarquis wants to merge 1 commit intoJakeWharton:masterfrom
SimonMarquis:patch/view_source_custom_tabs
Open
View Source should always open a ChromeCustomTab, fix #41#42SimonMarquis wants to merge 1 commit intoJakeWharton:masterfrom SimonMarquis:patch/view_source_custom_tabs
View Source should always open a ChromeCustomTab, fix #41#42SimonMarquis wants to merge 1 commit intoJakeWharton:masterfrom
SimonMarquis:patch/view_source_custom_tabs
Conversation
SimonMarquis
changed the title
View Source should always open a ChromeCustomTabView Source should always open a ChromeCustomTab, fix #41
SimonMarquis
changed the title
View Source should always open a ChromeCustomTab, fix #41View Source should always open a ChromeCustomTab, fixes #41
SimonMarquis
changed the title
View Source should always open a ChromeCustomTab, fixes #41View Source should always open a ChromeCustomTab, fix #41
jaredsburrows
approved these changes
Feb 3, 2018
|
Can you post screenshots? |
Author
|
What kind of screenshot do you want since there is no UI changes 😕 ? |
Added a helper class with companion methods to build the root CustomTabsIntent and share the same default resources: color, default action, maybe animations?
Author
|
|
@SimonMarquis This looks great! |
JakeWharton
force-pushed
the
master
branch
4 times, most recently
from
ccd37b0 to
bd5a066
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a helper class with companion methods to build the root CustomTabsIntent and share the same default resources: color, default action, maybe animations?